WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] fix build when CONFIG_COMPAT disabled

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>,"Keir Fraser" <keir@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] fix build when CONFIG_COMPAT disabled
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Thu, 11 Jan 2007 16:31:28 +0000
Cc: John Levon <levon@xxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 11 Jan 2007 08:29:34 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C1CC0C8D.77B4%keir@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <45A668F1.76E4.0078.0@xxxxxxxxxx> <C1CC0C8D.77B4%keir@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Keir Fraser <keir@xxxxxxxxxxxxx> 11.01.07 16:47 >>>
>On 11/1/07 15:42, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:
>
>> Properly conditionalize two places where compat-only structure fields get
>> accessed, and avoid compiler warnings on unused variables in two other
>> places.
>
>Should we bother to #ifdef where we don't need to? It's ugly and the
>compiler should be able to remove dead code where a condition evaluates to
>zero at compile time: we already have IS_COMPAT(d) hardcoded to zero if
>!CONFIG_COMPAT, which is enough to give the compiler a fair chance.

Generally no, but in the one case in the patch we have to, as the structure
member (mm_arg_xlat_l3) doesn't exist without CONFIG_COMPAT.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel