WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Partial fix for compat build non-portability

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>,<john.levon@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Partial fix for compat build non-portability
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Wed, 10 Jan 2007 17:43:04 +0000
Delivery-date: Wed, 10 Jan 2007 09:41:12 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <09c345f40063806e220e.1168450161@xenbld>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <09c345f40063806e220e.1168450161@xenbld>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>--- a/xen/include/Makefile
>+++ b/xen/include/Makefile
>@@ -2,8 +2,28 @@ ifneq ($(CONFIG_COMPAT),)
> 
> compat-arch-$(CONFIG_X86) := x86_32
> 
>-headers-y                 := $(shell echo public/*.h | sed -e 
>'s,[^[:space:]]*-[^[:space:]]*,,g' -e
's,public/,compat/,g')
>-headers-y                 := $(filter-out %/dom0_ops.h,$(headers-y))
>+headers-y := \
>+    compat/acm.h \
>+    compat/acm_ops.h \
>+    compat/callback.h \
>+    compat/domctl.h \
>+    compat/elfnote.h \
>+    compat/event_channel.h \
>+    compat/features.h \
>+    compat/grant_table.h \
>+    compat/kexec.h \
>+    compat/memory.h \
>+    compat/nmi.h \
>+    compat/physdev.h \
>+    compat/platform.h \
>+    compat/sched.h \
>+    compat/sysctl.h \
>+    compat/trace.h \
>+    compat/vcpu.h \
>+    compat/version.h \
>+    compat/xen.h \
>+    compat/xencomm.h \
>+    compat/xenoprof.h
> headers-$(CONFIG_X86)     += compat/arch-x86/xen.h
> headers-$(CONFIG_X86)     += compat/arch-x86/xen-$(compat-arch-y).h
> headers-y                 += compat/arch-$(compat-arch-y).h compat/xlat.h

I certainly dislike this hunk - I intentionally didn't do it this way, as I 
wanted to
prevent having to touch this Makefile every time a header gets added/removed.
If the current mechanism is too ugly (which I tend to agree) let's just do it by
more explicit filtering, i.e. add xen-compat.h along with dom0_ops.h and
remove all arch-*.h items via sed as is currently being done.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel