 Home |
Products |
Support |
Community |
News |
xen-devel
[Xen-devel] Re: [PATCH] kexec/kdump: fix grammar in comment
| To: | Horms <horms@xxxxxxxxxxxx> |
|---|---|
| Subject: | [Xen-devel] Re: [PATCH] kexec/kdump: fix grammar in comment |
| From: | Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx> |
| Date: | Wed, 10 Jan 2007 09:29:18 +0000 |
| Cc: | xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Magnus Damm <magnus.damm@xxxxxxxxx> |
| Delivery-date: | Wed, 10 Jan 2007 01:39:16 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <20070110080337.GA4687@xxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <20070110080337.GA4687@xxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On Wed, 2007-01-10 at 17:03 +0900, Horms wrote:
> Fix the grammar in the comment that features in
> xen_machine_kexec_setup_resources(). The current
> edition is a bit odd.
What I was trying to say is that we allow a possible memory leak because
the failure is unexpected and the amount is small, your version doesn't
really convey that information.
I've changed it to:
* It isn't possible to free xen_phys_cpus this early in the
* boot. Failure at this stage is unexpected and the
* amount of memory is small therefore we tolerate the
* potential leak.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] Re: [PATCH] Fix parse_size_and_unit() breakage in xen-3.0.4-testing (kdump broken), Ian Campbell |
|---|---|
| Next by Date: | [Xen-devel] Re: [PATCH] kexec/kdump: remove unnecessary incusion of asm/fixmap.h, Ian Campbell |
| Previous by Thread: | [Xen-devel] [PATCH] kexec/kdump: fix grammar in comment, Horms |
| Next by Thread: | [Xen-devel] Re: [PATCH] kexec/kdump: fix grammar in comment, Horms |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
