WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] x86_emulate adjustments

To: Jan Beulich <jbeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] x86_emulate adjustments
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Fri, 05 Jan 2007 12:05:03 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 05 Jan 2007 04:04:50 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <459E4B54.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Accwwbsm+bNjuJy0EduFdAAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] x86_emulate adjustments
User-agent: Microsoft-Entourage/11.2.5.060620
On 5/1/07 11:57, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> I can't see, however, what value there would particularly be in merging the
> privop decoder into x86_emulate - it's pretty orthogonal to the current
> functionality there, except for the memory accessed resulting from ins/outs.
> To a lesser degree, merging the hvm_instrlen into the main code seems not
> desirable for performance reasons, unless you mean to share the lookup table,
> but keep the routine separate.

Yes, the table-driven hvm_instrlen will stay I think. The generic
hvm_instrlen() is only used by the mmio emulator, and that's going away.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel