xen-devel

[Top] [All Lists]

Re: [Xen-devel] [PATCH] Improve XendCheckpoint's forkHelper error handli

from [Brendan Cully]

[Permanent Link][Original]

To:	xen-devel@xxxxxxxxxxxxxxxxxxx
Subject:	Re: [Xen-devel] [PATCH] Improve XendCheckpoint's forkHelper error handling
From:	Brendan Cully <brendan@xxxxxxxxx>
Date:	Fri, 15 Dec 2006 20:46:39 -0800
Delivery-date:	Fri, 15 Dec 2006 20:46:41 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<f2e7504c6693b80c98bb.1166060772@xxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to:	xen-devel@xxxxxxxxxxxxxxxxxxx
References:	<f2e7504c6693b80c98bb.1166060772@xxxxxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mutt/1.5.13 (2006-10-30)

On Wednesday, 13 December 2006 at 17:46, Brendan Cully wrote:
> # HG changeset patch
> # User Brendan Cully <brendan@xxxxxxxxx>
> # Date 1166060750 28800
> # Node ID f2e7504c6693b80c98bb0b5368f3f7a4e5021333
> # Parent  147608edc24993eaff17fd57709c77b8e2fee6b2
> Improve XendCheckpoint's forkHelper error handling.
> 
> When inputHandler raises an exception, close stdin and stdout in the
> child before attempting to close stderr, which is held open by a
> separate thread. Without this patch, exceptions raised by device
> migration caused xend to hang on child.childerr.close().
> 
> Signed-off-by: Brendan Cully <brendan@xxxxxxxxx>

*bump*

it's pretty easy to wedge xend without this patch. Just have
migrateDevices return an error code, eg by running an
external-device-migrate script that returns 1.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] Improve XendCheckpoint's forkHelper error handling, Brendan Cully Re: [Xen-devel] [PATCH] Improve XendCheckpoint's forkHelper error handling, Brendan Cully <= Re: [Xen-devel] [PATCH] Improve XendCheckpoint's forkHelper error handling, Ewan Mellor

Previous by Date:	[Xen-devel] [PATCH] Fix error message when detaching block devices, Stefan Berger
Next by Date:	Re: [Xen-devel] [PATCH] Export Multicore information, Keir Fraser
Previous by Thread:	[Xen-devel] [PATCH] Improve XendCheckpoint's forkHelper error handling, Brendan Cully
Next by Thread:	Re: [Xen-devel] [PATCH] Improve XendCheckpoint's forkHelper error handling, Ewan Mellor
Indexes:	[Date] [Thread] [Top] [All Lists]