WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Add a --force option to detach operations

To: Keir Fraser <keir@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Add a --force option to detach operations
From: Glauber de Oliveira Costa <gcosta@xxxxxxxxxx>
Date: Thu, 14 Dec 2006 11:48:40 -0500
Cc: Glauber de Oliveira Costa <glommer@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 14 Dec 2006 05:48:35 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C1A70247.6137%keir@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Red Hat
References: <C1A70247.6137%keir@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, 2006-12-14 at 13:29 +0000, Keir Fraser wrote:
> On 14/12/06 12:52, "Glauber de Oliveira Costa" <glommer@xxxxxxxxx> wrote:
> 
> > How can we be more brutal than that ? The only non-brutal thing I've put 
> > there
> > is denying disconnection when still in Connected state. But if for
> > some reason the frontend does not want to disconnect, then the tools
> > have no power over it. It can simply crash guest.
> > 
> > Example: attach a device, mount it at guest, and try to detach it
> > using --force. It should not force it, as it crashes the guest.
> 
> Don't use --force if you don't know what you're doing is a reasonable
> caveat. You're on flakey ground if you have to use it in any case as
> something is obviously screwed.

These kind of things can happen by accident. And in case an accident
happens, it does not seems a good idea to crash the guest.

Moreover, the lack of any kind of timeout can lead netfront to leak
memory. If the stores are released too early, backend may be unable to
release the references, and frontend will leak. I see no way of having
any guarantee of being in a termination state, so we will not be able to
to be sure it is safe to remove the entries anyway. But tests I made
with that timeout value lead to no leaks. 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>