WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [patch] Add kexec_ops & function pointers

To: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [patch] Add kexec_ops & function pointers
From: Gerd Hoffmann <kraxel@xxxxxxx>
Date: Tue, 12 Dec 2006 13:48:25 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Magnus Damm <magnus.damm@xxxxxxxxx>
Delivery-date: Tue, 12 Dec 2006 04:49:30 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1165922822.23643.34.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20061208161729.913385000@xxxxxxx> <aec7e5c30612112312s268d173h5cd3bece08034614@xxxxxxxxxxxxxx> <1165922822.23643.34.camel@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 1.5.0.8 (X11/20060911)
Ian Campbell wrote:
> On Tue, 2006-12-12 at 16:12 +0900, Magnus Damm wrote:
>> Basically, machine_kexec() should be converted to kexec_ops.kexec() in
>> two places. The second place is unfortunately located in
>> linux/kernel/sys.c which does not exist in sparse yet. So that needs
>> to be resolved somehow.
> 
> Hiding the indirections through the function table in the header via
> defines or inline functions would make things a lot cleaner in my
> opinion and as a bonus avoid this addition to the sparse tree.

No.  As machine_kexec() continues to exist (and is the default for
kexec_ops.kexec) you can't just turn that into a macro.  You have to
either fix the two callers (as done by the patch) or rename the function
to something different in arch/*/kernel/machine_kexec.c in order to be
able to reuse the name for the macro.

cheers,
  Gerd

-- 
Gerd Hoffmann <kraxel@xxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel