WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] Xen Crashes when releasing gnttab mappings - of a crashe

To: "Keir Fraser" <keir@xxxxxxxxxxxxx>, "xen-devel" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] Xen Crashes when releasing gnttab mappings - of a crashed domain.
From: "Moffie, Micha" <micha.moffie@xxxxxx>
Date: Tue, 21 Nov 2006 15:52:29 -0000
Delivery-date: Tue, 21 Nov 2006 07:52:42 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C188BE8A.4D31%keir@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AccNc31su++dBHlmEduJYgAX8io7RQAAhe0AAAEUTeEAArTeIA==
Thread-topic: [Xen-devel] Xen Crashes when releasing gnttab mappings - of a crashed domain.
Yes, fixed. 


> +        domain_crash(ld); /* naughty... */

By why do you crash the local domain if the reference can not be
ungranted?
Is there no way to clean up? And if ld == 0?

Thanks,
:)
Micha.

-----Original Message-----
From: Keir Fraser [mailto:keir@xxxxxxxxxxxxx] 
Sent: 21 November 2006 14:33
To: Moffie, Micha; xen-devel
Subject: Re: [Xen-devel] Xen Crashes when releasing gnttab mappings - of
a crashed domain. 

On 21/11/06 14:09, "Moffie, Micha" <micha.moffie@xxxxxx> wrote:

> 1. Setting unmap_op.dev_bus_addr removes the BUG and all is well.
> 2. But crashing Xen - even with our error - doesn't seem to be a 
> healthy choice.

Does the attached patch fix this issue? It's against unstable tip -- may
apply to your tree with patch fuzz.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel