WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Fix core dumps of guests > 2 GB in size on i386

To: "Daniel P. Berrange" <berrange@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Fix core dumps of guests > 2 GB in size on i386
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Fri, 17 Nov 2006 09:52:15 +0000
Delivery-date: Fri, 17 Nov 2006 01:52:30 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20061115220221.GN17466@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AccKLg+bTflSQ3YhEdu6aAAX8io7RQ==
Thread-topic: [Xen-devel] Fix core dumps of guests > 2 GB in size on i386
User-agent: Microsoft-Entourage/11.2.5.060620
On 15/11/06 22:02, "Daniel P. Berrange" <berrange@xxxxxxxxxx> wrote:

> The attached patch adds the O_LARGEFILE flag when opening the file. It
> is also neccessary to add additional CFLAGS & LDFLAGS to enable use of
> the POSIX Largefile  standard.  There are two ways to enable LFS support,
> in implicit mode all types, functions & macros are automatically changed
> to the 64 bit variants at compile time - this however changes the ABI
> contract - eg size_t is now 64-bits instead of 32.

I like the implicit method. I think it's unlikely to bite us. A lot of tools
subdirs are defining _FILE_OFFSET_BITS=64 anyway (and not using getconf!).
I'll provide a portable common CFLAGS/LDFLAGS addition in tools/Rules.mk.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel