WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] HVM cleanups

To: "Li, Xin B" <xin.b.li@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] HVM cleanups
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Fri, 17 Nov 2006 08:30:55 +0000
Delivery-date: Fri, 17 Nov 2006 00:31:14 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <B30DA1341B0CFA4893EF8A36B40B5C5D6C40D1@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AccJoV4MxuRi2+t0S4ytjjt+U9eghwACMUsQAB0d0+AAAQYYBw==
Thread-topic: [Xen-devel] [PATCH] HVM cleanups
User-agent: Microsoft-Entourage/11.2.5.060620
On 17/11/06 8:12 am, "Li, Xin B" <xin.b.li@xxxxxxxxx> wrote:

> now in xen/arch/x86/hvm directory we have hvm.c, platform.c, io.c,
> intercept.c; I think these some of these file names are not clear, sometimes I
> don't remember which file a hvm function lives in :-(, maybe it's time to
> clean them, for example maybe it's better to name platform.c as mmio.c, and
> some functions need to be moved from one file to another, also we can merge
> some files.

I agree that this needs cleaning up at some point, as control flow seems to
jump randomly across these files. But I live in hope that the MMIO decoder
will die at some point soon and that should kill off much of io.c and
platform.c anyway. What about all the other stuff? Do you have a plan
already about: (a) what subsystems/functions we have to support; and (b)
what filenames you think they belong in? Renames are a pain for some people
so I'd like any rename to happen only once.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>