WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [Qemu-devel] Recursion in cpu_physical_memory_rw

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, Paul Brook <paul@xxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [Qemu-devel] Recursion in cpu_physical_memory_rw
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Wed, 15 Nov 2006 07:55:48 +0000
Cc: Xen Development Mailing List <xen-devel@xxxxxxxxxxxxxxxxxxx>, qemu-devel@xxxxxxxxxx
Delivery-date: Tue, 14 Nov 2006 23:56:23 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20061115025839.GA22608@xxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AccIi3Y0tIWqnnR+EduBbAANk04WTA==
Thread-topic: [Xen-devel] Re: [Qemu-devel] Recursion in cpu_physical_memory_rw
User-agent: Microsoft-Entourage/11.2.5.060620
On 15/11/06 2:58 am, "Herbert Xu" <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

>> It isn't always system memory. Some DMA controllers deliberately write to
>> device FIFOs. There are also several devices which map areas of onboard RAM.
>> At minimum you need to make those to use RAM mappings rather than MMIO.
> 
> I'm not suggesting that we change all existing users of cpu_physical_*
> to a new interface that only accessed RAM.  However, for cases where it
> is obvious that only system RAM is intended (e.g., rtl8139), it makes
> sense to bypass MMIO handlers.

Could we add a recursion counter to the memory-access functions, and bail if
it reaches some limit?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel