WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] remove HVM halt timer

To: "Li, Xin B" <xin.b.li@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] remove HVM halt timer
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Fri, 10 Nov 2006 10:57:24 +0000
Delivery-date: Fri, 10 Nov 2006 02:57:44 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <B30DA1341B0CFA4893EF8A36B40B5C5D62EAA5@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AccEnswNUkAD/BhaQT+W4uZ/emiWdAAAYqyKAABK//AAAKXPCwAAhOTwAAQ0ySU=
Thread-topic: [Xen-devel] [PATCH] remove HVM halt timer
User-agent: Microsoft-Entourage/11.2.5.060620


On 10/11/06 08:59, "Li, Xin B" <xin.b.li@xxxxxxxxx> wrote:

> New patch attached.

Why did you remove the test of VCPU_running in pt_timer_fn()? There's no
need to continue running the timer when a vcpu is descheduled, as long as it
fires the first time (which it will).

Apart from that it looks good so I'll check in the rest.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel