WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Linux-specific blkif.py change

To: John Levon <levon@xxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Linux-specific blkif.py change
From: Brendan Cully <brendan@xxxxxxxxx>
Date: Wed, 1 Nov 2006 18:03:03 -0800
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 02 Nov 2006 13:48:18 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20061102014250.GA1575@xxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20061102014250.GA1575@xxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On 1-Nov-06, at 5:42 PM, John Levon wrote:


Changeset 11831:f5321161c649 has broken non-Linux domUs with this
change:

         devid = blkif.blkdev_name_to_number(dev)
+        if not devid:
+ raise VmError('Unable to find number for device (%s)' % (dev))
+

The immediate problem is that Solaris domU's have "0" for dev for the
first disk. So it's presumably matched on the hex re in util/blkif.py,
returning 0 and failing this incorrect check. There are other problems:

I don't know about the other stuff, but changing the check to

if devid is None:

should solve your immediate problem, right?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel