WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] removing event notification for HVM IRQ injection?

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>, <ssmith@xxxxxxxxxxxxx>
Subject: RE: [Xen-devel] removing event notification for HVM IRQ injection?
From: "Dong, Eddie" <eddie.dong@xxxxxxxxx>
Date: Sun, 22 Oct 2006 17:04:22 +0800
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Sun, 22 Oct 2006 02:04:50 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acb0J5WDC67RZQfzQNmF+ial5B6dhgAS0B3+AFGNkoA=
Thread-topic: [Xen-devel] removing event notification for HVM IRQ injection?
That looks fine:-)


From: Keir Fraser [mailto:Keir.Fraser@xxxxxxxxxxxx]
Sent: 2006年10月21日 2:09
To: Dong, Eddie; ssmith@xxxxxxxxxxxxx
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] removing event notification for HVM IRQ injection?

On 20/10/06 10:10 am, "Dong, Eddie" <eddie.dong@xxxxxxxxx> wrote:

       When looking at improving the HVM TPR acceleration, I noticed your previous patch (CSET:10974) replaced evtchn_set_pending in both hlt_timer_fn & vlapic_accept_irq with hvm_prod_vcpu. I am not sure for the purpose but at least one thing is missed after this patch: previous evtchn_set_pending may use physical IPI to interrupt target VP while hvm_prod_vcpu not. If the target VP is running, delivering guest IRQ  ( both hlt_timer_fn & vlapic_accept_irq ) to a running VP have to use physical IPI to interrupt the execution to inject IRQ, without this the logic may be wrong.

        
Can u share more lights with us?

I suggest killing hvm_prod_vcpu() entirely and callers use vcpu_kick() instead. I think vcpu_kick() does exactly what you want.

 -- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>