WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [patch] Fix 32bit xen-tools build.

To: John Levon <levon@xxxxxxxxxxxxxxxxx>, <kraxel@xxxxxxx>
Subject: Re: [Xen-devel] [patch] Fix 32bit xen-tools build.
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Sat, 21 Oct 2006 08:43:32 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Sat, 21 Oct 2006 00:54:50 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20061020122549.GA22733@xxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acb05Jsw2fuV8mDXEduTBwANk04WTA==
Thread-topic: [Xen-devel] [patch] Fix 32bit xen-tools build.
User-agent: Microsoft-Entourage/11.2.5.060620
On 20/10/06 1:25 pm, "John Levon" <levon@xxxxxxxxxxxxxxxxx> wrote:

>> -CFLAGS += -m32 -march=i686
>> -LIBDIR := lib
>> +CFLAGS  += -m32 -march=i686
>> +LDFLAGS += -m32
>> +ASFLAGS += -m32
>> +LIBDIR  := lib
> 
> Where is left that needs LDFLAGS/ASFLAGS to have the -m flags? It's
> wrong anyway, there should be nowhere that's not using $CFLAGS; see the
> previous discussion. We've had to disable a couple of directories for
> now, so probably it's in one of those?

Bit more context: anywhere that *is* using $(LD) directly should add
$(LDFLAGS_DIRECT) to the command line. This adds -mi386 or -mx86_64. The
linker does not understand -m32/-m64. But anywhere not doing tricky links
(e.g., with a GNU-specific script) should call the linker via the GCC
driver.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel