WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Fix pygrub with "many" kernels

To: Jeremy Katz <katzj@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fix pygrub with "many" kernels
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Thu, 05 Oct 2006 16:12:35 +0100
Delivery-date: Thu, 05 Oct 2006 08:13:06 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1159999027.25209.30.camel@xxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcbokK/b7oFyzFSDEduatwAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] Fix pygrub with "many" kernels
User-agent: Microsoft-Entourage/11.2.5.060620


On 4/10/06 22:57, "Jeremy Katz" <katzj@xxxxxxxxxx> wrote:

> Attached fixes running pygrub with many kernels to do proper scrolling
> 
> Signed-off-by: Jeremy Katz <katzj@xxxxxxxxxx>

+        if self.selected_image > self.start_image + maxy:
+            self.start_image = self.selected_image
+        if self.selected_image < self.start_image:
+            self.start_image = self.selected_image

Shouldn't the second line above be:
     self.start_image = self.selected_image - maxy

So that the selected image is the one at the bottom of the displayed
subsection of the list?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>