WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] [XEND] Remove hard tabs

To: Molle Bestefich <molle.bestefich@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] [XEND] Remove hard tabs
From: Hollis Blanchard <hollisb@xxxxxxxxxx>
Date: Thu, 21 Sep 2006 15:28:13 -0500
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 21 Sep 2006 13:33:15 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <62b0912f0609202258k6d399871tad27827ddb9b1137@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: IBM Linux Technology Center
References: <f7d90f962967a5a94fce.1158780092@xxxxxxxxxxxxxxxxxxxxx> <62b0912f0609202258k6d399871tad27827ddb9b1137@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, 2006-09-21 at 07:58 +0200, Molle Bestefich wrote:
> Hollis Blanchard:
> > [XEND] Remove hard tabs.
> 
> That's stupid, tabs are a relief to use when coding compared to spaces.

That's a separate conversation.

> > -       if type(devid) is str:
> > -           devicePath = '%s/device/%s' % (self.dompath, deviceClass)
> > -           for entry in xstransact.List(devicePath):
> > -               backend = xstransact.Read('%s/%s' % (devicePath, entry), 
> > "backend")
> > -               devName = xstransact.Read(backend, "dev")
> 
> > +        if type(devid) is str:
> > +            devicePath = '%s/device/%s' % (self.dompath, deviceClass)
> > +            for entry in xstransact.List(devicePath):
> > +            backend = xstransact.Read('%s/%s' % (devicePath, entry), 
> > "backend")
> > +            devName = xstransact.Read(backend, "dev")
> 
> Seems to me like you're breaking Python indentation rules now?

Hmm, that is a stupid mistake on my part...

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel