WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [XenPPC] [RFC][PATCH] Isolating ACM's architecture-depen

To: hollisb@xxxxxxxxxx
Subject: [Xen-devel] Re: [XenPPC] [RFC][PATCH] Isolating ACM's architecture-dependent parts
From: Stefan Berger <stefanb@xxxxxxxxxx>
Date: Wed, 13 Sep 2006 10:53:36 -0400
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, xen-ppc-devel@xxxxxxxxxxxxxxxxxxx, tristan.gingold@xxxxxxxx
Delivery-date: Wed, 13 Sep 2006 07:54:16 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1158159090.22458.1.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

hollisb@xxxxxxxxxxxxxxxxxxxxxxx wrote on 09/13/2006 10:51:29 AM:

> > +
> > +static inline
> > +int acm_x86_init(multiboot_info_t *mbi,
> > +                 unsigned int *initrdidx,
> > +                 unsigned long initial_images_start)
> > +{
> > +    return 0;
> > +}
> > +
> > +#endif
> > +
> > +#endif
>
> These are way too big to be static inlines. Make them regular functions
> please.
>
> Other than that, this patch seems great.


Don't want to have that checked in so far, though.

What about the multiboot code. Do you think PPC will be able to also use this part? Not that I would move it, it's more out of curiosity.

   Stefan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel