This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [patch] make ELF functions static

To: "Hollis Blanchard" <hollisb@xxxxxxxxxx>, "Ian Campbell" <Ian.Campbell@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [patch] make ELF functions static
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Wed, 30 Aug 2006 09:38:36 +0100
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, xen-ppc-devel <xen-ppc-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 30 Aug 2006 01:38:32 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1156921433.5190.26.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1156886133.29858.75.camel@xxxxxxxxxxxxxxxxxxxxx> <1156921433.5190.26.camel@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx> 30.08.06 09:03 >>>
>On Tue, 2006-08-29 at 16:15 -0500, Hollis Blanchard wrote:
>> Hi Ian, these functions should be static. It would only be a style issue
>> except PowerPC actually #includes elf.c twice, to support both 32- and
>> 64-bit ELF binaries. Please apply.
>Unfortunately they are referenced from outside this file
>I'm not sure what a good short term fix for you would be. Perhaps some
>preprocessor/CFLAGS magic to name them xen_elfnote32_foo and
>xen_elfnote64_foo when compiling powerpc?
>Hopefully long term the 32-on-64 work that is going on will lead to ELF
>code which doesn't need to be multiply compiled.

Why? It's simpler to compile it twice. I already posted draft patches to
do this, simply introducing an elf32.c that #define-s the relevant
symbols to alternative names and that only gets compiled when 64-bit
arches need it for supporting 32-bit binaries.


Xen-devel mailing list