This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [Patch][RFC] fix xc_ptrace_core for gdbserver-xen on?x86

To: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [Patch][RFC] fix xc_ptrace_core for gdbserver-xen on?x86_64.
From: Horms <horms@xxxxxxxxxxxx>
Date: Fri, 25 Aug 2006 17:00:39 +0900 (JST)
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 29 Aug 2006 02:01:23 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <52C6C7F5AD6922takebe_akio@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: tin/1.8.2-20060425 ("Shillay") (UNIX) (Linux/2.6.17-2-686 (i686))
On Fri, 25 Aug 2006 12:22:21 +0900, Akio Takebe wrote:
> [-- text/plain, encoding 7bit, charset: iso-2022-jp, 199 lines --]
> [-- Description: Mail message body --]
> Hi, x86_64 people
> I make a patch to fix xc_ptrace_core for gdbserver-xen on x86_64.
> But I'm not familiar with x86_64.
> Please review it.

Hi Takebe-san,

It seems generaly consistent with the i386 code, and looks generaly
fine, though I am not an expert on x86_64 either.

There seem to be three distinct portions of your patch.

1. Make nr_pages an unsigned long instead of a long

   This seems like it should be a separate patch as its really
   a trivial (but probably important) bugfix. Right?

2. Fill in map_domain_va_core() for x86_64

3. Get rid of m2p_array.

   I'm not sure what the relationship between 2 and 3 is.
   Is m2p_array no longer needed because of the changes in 2?
   Or is it a separate cleanup?

  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>