This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [patch 5/6] frontend device shutdown

To: Gerd Hoffmann <kraxel@xxxxxxx>, Xen devel list <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [patch 5/6] frontend device shutdown
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Sat, 19 Aug 2006 13:52:24 +0100
Delivery-date: Sat, 19 Aug 2006 06:01:41 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <44E47744.9070302@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcbDjlEYj4fi2S+BEdu36QANk04WTA==
Thread-topic: [Xen-devel] [patch 5/6] frontend device shutdown
User-agent: Microsoft-Entourage/
On 17/8/06 3:03 pm, "Gerd Hoffmann" <kraxel@xxxxxxx> wrote:

> + int shutdown_in_progress;

Get rid of this field in your next patch.

The use in xenbus_client.c should go away because you should unconditionally
move to state XenbusStateClosed, fixing up backend drivers as necessary.

The use in netfront.c doesn't make much sense to me. Is it a side effect of
needing to move into state XenbusStateInitialised (which will be going
away)? I think we should be able to do without it, anyway (maybe a fix to
backend drivers will be required).

The use in blkfront.c can be replaced by a check of system_state (e.g.,
(system_state == SYSTEM_RUNNING)) as defined in linux/kernel.h.

 -- Keir

Xen-devel mailing list