This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[XenPPC] Re: [Xen-devel] fix vga.c compilation

To: Hollis Blanchard <hollisb@xxxxxxxxxx>
Subject: [XenPPC] Re: [Xen-devel] fix vga.c compilation
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Wed, 16 Aug 2006 16:40:02 +0100
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, Alex Williamson <alex.williamson@xxxxxx>, xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 16 Aug 2006 08:43:33 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1155742553.669.16.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-ppc-devel-request@lists.xensource.com?subject=help>
List-id: Xen PPC development <xen-ppc-devel.lists.xensource.com>
List-post: <mailto:xen-ppc-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-ppc-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcbBSjzkezlyRC09Edu/QAAKle7CWA==
Thread-topic: [Xen-devel] fix vga.c compilation
User-agent: Microsoft-Entourage/

On 16/8/06 4:35 pm, "Hollis Blanchard" <hollisb@xxxxxxxxxx> wrote:

> On Wed, 2006-08-16 at 11:49 +0100, Keir Fraser wrote:
>> @@ -159,12 +160,8 @@
>>   * into a single 16-bit quantity */
>>  #define VGA_OUT16VAL(v, r)       (((v) << 8) | (r))
>> -#if defined(__i386__) || defined(__x86_64__)
>> -# define vgabase 0
>> -# define VGA_OUTW_WRITE
>> -# define vga_readb(x) (*(x))
>> -# define vga_writeb(x,y) (*(y) = (x))
>> -#endif
>> +#define vgabase 0         /* use in/out port-access macros  */
>> +#define VGA_OUTW_WRITE    /* can use outw instead of 2xoutb */
> When would you redefine vgabase?

Right there, with ifdef's, when an arch comes along that requires it.

>> +const struct font_desc font_vga_8x8, font_vga_8x14, font_vga_8x16;
> I think there could be a cleaner separation between console.c and vga.c,
> and that would avoid needing to redefine these symbols. For example,
> right now cls(), init_vga(), and others still live in console.c, most of
> them manually testing vgacon_enabled.
> What would be better is a system where console drivers (i.e. serial and
> vga) register themselves at boot time, so console.c putchar() becomes:

Well, that'd be more important if it were likely that the powerpc dummy
versions were going to stick around. Since they're not, I don't think we
need to over-engineer a solution looking for a problem.

 -- Keir

Xen-ppc-devel mailing list