This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] [PATCH 2/3] xend: Add multiple cpumasks support

To: "Ryan Harper" <ryanh@xxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH 2/3] xend: Add multiple cpumasks support
From: "Ian Pratt" <m+Ian.Pratt@xxxxxxxxxxxx>
Date: Mon, 14 Aug 2006 23:40:53 +0100
Cc: Ryan Grimm <grimm@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 14 Aug 2006 15:41:13 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Aca/79nYD7magjGHRwuK0tPuhiFVQgAAhhxg
Thread-topic: [Xen-devel] [PATCH 2/3] xend: Add multiple cpumasks support
> > Either Keir's cpu[X] = "Y" approach or my cpu = [ "A","B","C" ]
> > seem workable.
> Your last email seemed to indicate to me that you didn't like using
> quoted values in a list to separate per-vcpu cpumask values.  Maybe I
> was mistaken.

If it's an honest python list I have no problem. Your example appeared
to be some quoting within a string.

> > Keir's approach is rather ill defined if someone tries using both
> > and cpu[X]= in the same config file, but I don't see that as a big
> > problem.  Take your pick :-)
> I'm leaning toward the list notation since I already have code that
> parses that properly.

My approach is a list too...

> > BTW: does the right thing happen in the face of vcpu hot plugging?
> > if I unplug a vcpu and put it back in do I keep the old mask? If I
> > vcpus what mask do they get?
> unplug events only affect a vcpu's status.  The internal struct
> vcpu in the hypervisor is not de-allocated/re-allocated during hotplug
> events.
> We don't currently support a hotadd for vcpus that weren't allocated
> domain creation time.  The current method for simulating hot-add would
> be to start a domain with 32 VCPUS and disable all by the number of
> vcpus you currently want.  Ryan Grimm posted a patch back in February
> that had xend do this by adding a new config option, max_vcpus, which
> was used when calling xc_domain_max_vcpus() having the hypervisor
> that max number of vcpus and then using the vcpus parameter to
> how many to bring online.

I like the idea of having a vcpus_max

> > We should probably add a 'vcpu-pin' variant that enables the mask to
> > set for all vcpus. Perhaps '-1' for the vcpu number? Or should we
> > 'vcpu-pin-all'?
> vcpu-pin using -1 is probably the quickest, least intrusive method to
> get this behavior.  We could also use a keyword, all for instance:
> xm vcpu-pin vm1 all 0-4,^5


> > [secondly, what do you think about implicitly defaulting the mask to
> > 1's if the first item in a cpu mask is an exclusion? e.g. ^1]
> That makes sense.  I'll include a patch in the set to add this


Xen-devel mailing list