This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [Xen-changelog] [XENBUS] Avoid direct use of xen_start_i

To: Steven Smith <ssmith@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [Xen-changelog] [XENBUS] Avoid direct use of xen_start_info.
From: Hollis Blanchard <hollisb@xxxxxxxxxx>
Date: Mon, 14 Aug 2006 14:37:48 -0500
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ppc-devel <xen-ppc-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 14 Aug 2006 12:37:33 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <E1GChyz-0004xc-M8@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: IBM Linux Technology Center
References: <E1GChyz-0004xc-M8@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
This is great, because on PowerPC we're looking to drop struct
start_info entirely. However, I notice there are still a fair number of
'xen_start_info' references in drivers/xen. Are there more of these
patches coming Steven, or since HVM guests don't use those drivers
you're not pursuing them?

On Mon, 2006-08-14 at 19:20 +0000, Xen patchbot-unstable wrote:
> # HG changeset patch
> # User kfraser@xxxxxxxxxxxxxxxxxxxxx
> # Node ID e061f14161b052b3287a1e41222cfa292a194fc2
> # Parent  9519445d9e9d7b8bd48fcd93d1bba485508ddbff
> [XENBUS] Avoid direct use of xen_start_info. It's unevailable when
> building as a separate driver for an HVM guest.
> Signed-off-by: Steven Smith <ssmith@xxxxxxxxxxxxx>
> Signed-off-by: Keir Fraser <keir@xxxxxxxxxxxxx>


> @@ -1014,8 +1017,13 @@ static int __init xenbus_probe_init(void
>               if (xsd_port_intf)
>                       xsd_port_intf->read_proc = xsd_port_read;
>  #endif
> -     } else
> +     } else {
>               xenstored_ready = 1;
> +             xen_store_evtchn = xen_start_info->store_evtchn;
> +             xen_store_mfn = xen_start_info->store_mfn;
> +     }
> +
> +     xen_store_interface = mfn_to_virt(xen_store_mfn);
>       /* Initialize the interface to xenstore. */
>       err = xs_init();

Could we abstract this part more please? I think calling into an
arch-provided xen_get_store_mfn() function would be good. (And of course
the same for store_evtchn and the console_* equivalents.)

Hollis Blanchard
IBM Linux Technology Center

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>