Re: [Xen-devel] [PATCH 2/3] xend: Add multiple cpumasks support

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 14/8/06 5:57 pm, "Ryan Harper" <ryanh@xxxxxxxxxx> wrote:

> This patch modifies xend to accept and parse multiple cpumask strings
> from the cpus parameter.  The cpus string stays the same, but it now
> can parse either a python list of strings:
> 
> [ '2-5, '2-5', '2-5' ]
> 
> A regular string with ", " as the separator:
> 
> "2-5, 2-5, 2-5, 2-5"
> 
> or a mixture of both:
> 
> [ 2-5, '2-5', 2-5, '2-5' ]

This isn't really a mixture of both, is it? It looks syntactically incorrect
(e.g., first 2-5 is unquoted so not a string).

I'm not sure about the use of ', ' as a delimiter. It would be less
confusing to strictly require the use of the list form. I would imagine it's
then clearest used as:
Cpus = []
Cpus[0] = '2-5'
Cpus[1] = '3-4'
...

Trying to read long lists of cpu constraints with spaces in will make people
go cross-eyed!

 -- Keir

> all result in the same list of integers which is used to create the
> cpumask for each vcpu in the domain.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel