This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 2/3] xend: Add multiple cpumasks support

To: Ryan Harper <ryanh@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 2/3] xend: Add multiple cpumasks support
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Mon, 14 Aug 2006 18:37:21 +0100
Delivery-date: Mon, 14 Aug 2006 10:37:47 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20060814165701.GL1694@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Aca/yEujiiJMByu7EduTIwAKle7CWA==
Thread-topic: [Xen-devel] [PATCH 2/3] xend: Add multiple cpumasks support
User-agent: Microsoft-Entourage/
On 14/8/06 5:57 pm, "Ryan Harper" <ryanh@xxxxxxxxxx> wrote:

> This patch modifies xend to accept and parse multiple cpumask strings
> from the cpus parameter.  The cpus string stays the same, but it now
> can parse either a python list of strings:
> [ '2-5, '2-5', '2-5' ]
> A regular string with ", " as the separator:
> "2-5, 2-5, 2-5, 2-5"
> or a mixture of both:
> [ 2-5, '2-5', 2-5, '2-5' ]

This isn't really a mixture of both, is it? It looks syntactically incorrect
(e.g., first 2-5 is unquoted so not a string).

I'm not sure about the use of ', ' as a delimiter. It would be less
confusing to strictly require the use of the list form. I would imagine it's
then clearest used as:
Cpus = []
Cpus[0] = '2-5'
Cpus[1] = '3-4'

Trying to read long lists of cpu constraints with spaces in will make people
go cross-eyed!

 -- Keir

> all result in the same list of integers which is used to create the
> cpumask for each vcpu in the domain.

Xen-devel mailing list