This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH][TOOLS] allow the selection of blktap and firmwar

To: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][TOOLS] allow the selection of blktap and firmware thru config files
From: Julian Chesterfield <jac90@xxxxxxxxx>
Date: Thu, 10 Aug 2006 11:08:18 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, julian.chesterfield@xxxxxxxxxxxxx
Delivery-date: Thu, 10 Aug 2006 03:10:33 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <DE24EEAA-AD81-4020-B33D-8A1FCEE2048E@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C0FFCDC1.B23%Keir.Fraser@xxxxxxxxxxxx> <DE24EEAA-AD81-4020-B33D-8A1FCEE2048E@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thanks Jim. I'll post the patch to the libaio folks also so we can keep things in synch.

- Julian

On 10 Aug 2006, at 02:06, Jimi Xenidis wrote:

On Aug 9, 2006, at 12:37 PM, Keir Fraser wrote:
On 9/8/06 1:34 pm, "Jimi Xenidis" <jimix@xxxxxxxxxxxxxx> wrote:

  2) nasty build break in libaio

Shouldn't you fix that instead of skirting the issue? :-)

I knew you would say that! :)
Will you take patches to libaio, or are you expecting that to stay
clean to the distro?
I may have missed this discussion, but why can't we just use the one
that comes with the Distro?

That's a question for Julian (cc'ed). I assume it *ought* to work on
powerpc, so perhaps at worst we add a patch and also send it upstream.

ok, I checked in the fix, you will get it in the next pull from our merge tree.
Here it is for reference:
changeset:   11432:e60de2425ec47caf50301b6aa164c61ff1540eb7
user:        Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
date:        Wed Aug 09 15:38:37 2006 -0400
files:       tools/libaio/src/syscall-ppc.h
[POWERPC][TOOLS] fix header so libaio builds

Signed-off-by: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>

diff -r 0bb2e9a96c33777247319e6ff3428212bf5c1f17 -r e60de2425ec47caf50301b6aa164c61ff1540eb7 tools/libaio/src/syscall-ppc.h
--- a/tools/libaio/src/syscall-ppc.h    Wed Aug 09 15:37:42 2006 -0400
+++ b/tools/libaio/src/syscall-ppc.h    Wed Aug 09 15:38:37 2006 -0400
@@ -1,3 +1,6 @@
+#include <asm/unistd.h>
+#include <errno.h>
#define __NR_io_setup           227
#define __NR_io_destroy         228
#define __NR_io_getevents       229
@@ -9,7 +12,7 @@
* "sc; bnslr" sequence) and CR (where only CR0.SO is clobbered to signal
  * an error return status).
+#ifndef __syscall_nr
#define __syscall_nr(nr, type, name, args...)                           \
        unsigned long __sc_ret, __sc_err;                               \
        {                                                               \
@@ -37,6 +40,7 @@
        }                                                               \
        if (__sc_err & 0x10000000) return -((int)__sc_ret);         \
        return (type) __sc_ret
#define __sc_loadargs_0(name, dummy...)                                 \
        __sc_0 = __NR_##name

Xen-devel mailing list

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>