This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] omission in x86-64's entry-xen.S ?

To: Jan Beulich <jbeulich@xxxxxxxxxx>, <jun.nakajima@xxxxxxxxx>
Subject: Re: [Xen-devel] omission in x86-64's entry-xen.S ?
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Tue, 08 Aug 2006 08:38:34 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 08 Aug 2006 00:39:01 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <44D85AA3.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Aca6vab/5WTOWCawEduaRAAKle7CWA==
Thread-topic: [Xen-devel] omission in x86-64's entry-xen.S ?
User-agent: Microsoft-Entourage/

On 8/8/06 8:34 am, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> following sysret_signal there is a 'cli' left, but the hypervisor doesn't even
> emulate this anymore as equivalent of
> clearing evtchn_upcall_mask - I'm fairly certain XEN_BLOCK_EVENTS() is meant
> here, otherwise a comment should explain
> why this needs to keep the native instruction.

Any stupidities you see in x86/64 entry-xen.S almost certainly really are
bugs. Please send a patch!

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>