This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH][RFC] open HVM backing storage with O_SYNC

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH][RFC] open HVM backing storage with O_SYNC
From: Rik van Riel <riel@xxxxxxxxxx>
Date: Fri, 28 Jul 2006 16:21:29 -0400
Delivery-date: Fri, 28 Jul 2006 13:21:54 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <44CA4330.7010007@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Red Hat, Inc
References: <44C9B75B.7060809@xxxxxxxxxx> <44CA4330.7010007@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (X11/20060614)
Rik van Riel wrote:
Rik van Riel wrote:

Any comments on this patch?

I got some comments from Alan, who would like to see this behaviour
tunable with hdparm from inside the guest.  This requires larger
qemu changes though, to be specific an ->fsync callback into each
of the backing store drivers, so that is something for the qemu
mailing list.

Considering the AIO-based development going on in the qemu community,
I think we should stick with the O_SYNC band-aid.  The idea Alan
described would just be a fancier band-aid.

The current bottleneck seems to be that MAX_MULT_COUNT is only 16.

Upon closer inspection of the code, this seems to not be the case for LBA48 transfers.

"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan

Xen-devel mailing list