This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] [PATCH] Add lost logic for VGA initialization

To: <Christian.Limpach@xxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] Add lost logic for VGA initialization
From: "Zhang, Xiantao" <xiantao.zhang@xxxxxxxxx>
Date: Thu, 27 Jul 2006 09:47:47 +0800
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 26 Jul 2006 18:48:45 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcawvvWLQHjPLoHfSKCYjz2mYWjnWQAX073g
Thread-topic: [Xen-devel] [PATCH] Add lost logic for VGA initialization
Hi, Christian
        Thank you for your comments. But I check the patch on tip. Seems the 
following line not in upstream. I don't know why this part was lost when 
diff -r 254c090854de tools/ioemu/hw/vga.c
--- a/tools/ioemu/hw/vga.c      Wed Jul 26 15:59:36 2006 -0600
+++ b/tools/ioemu/hw/vga.c      Thu Jul 27 09:27:03 2006 +0800
@@ -1953,6 +1953,7 @@ void vga_common_init(VGAState *s, Displa
                          vga_screen_dump, s);
     /* XXX: currently needed for display */
     vga_state = s;
+    vga_bios_init(s);
Thanks & Best Regards

OTC,Intel Corporation

> -----Original Message-----
> From: Christian Limpach [mailto:christian.limpach@xxxxxxxxx]
> Sent: 2006年7月26日 22:23
> To: Zhang, Xiantao
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxx; xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-devel] [PATCH] Add lost logic for VGA initialization
> On 7/26/06, Zhang, Xiantao <xiantao.zhang@xxxxxxxxx> wrote:
> > This patch adds lost logic for vga initialization. It was lost after
> > changing to new Qemu.
> > Signed-off-by : Kevin Tian <kevin.tian@xxxxxxxxx>
> > Signed-off-by : Zhang Xiantao <xiantao.zhang@xxxxxxxxx>
> I've applied this -- it would be nice if you could cleanup the code
> some more to use arrays to initialize s->sr[], s->gr[], s->ar[] and
> s->cr[].  Thanks!
>     christian

Xen-devel mailing list