|
xen-devel
[Xen-devel] Re: [RFC PATCH 23/33] subarch TLB support
|
To: |
chrisw@xxxxxxxxxxxx |
|
Subject: |
[Xen-devel] Re: [RFC PATCH 23/33] subarch TLB support |
|
From: |
David Miller <davem@xxxxxxxxxxxxx> |
|
Date: |
Tue, 18 Jul 2006 13:39:24 -0700 (PDT) |
|
Cc: |
akpm@xxxxxxxx, zach@xxxxxxxxxx, jeremy@xxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, ian.pratt@xxxxxxxxxxxxx, rusty@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, ak@xxxxxxx, virtualization@xxxxxxxxxxxxxx, Christian.Limpach@xxxxxxxxxxxx |
|
Delivery-date: |
Thu, 20 Jul 2006 05:22:51 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<20060718091954.271792000@xxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<20060718091807.467468000@xxxxxxxxxxxx> <20060718091954.271792000@xxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
From: Chris Wright <chrisw@xxxxxxxxxxxx>
Date: Tue, 18 Jul 2006 00:00:23 -0700
> + BUG_ON(HYPERVISOR_mmuext_op(&op, 1, NULL, DOMID_SELF) < 0);
Although it happens to work currently, I think we should get out of
the habit of putting operations with wanted side effects into BUG_ON()
calls. The following is therefore more preferable:
ret = HYPERVISOR_mmuext_op(&op, 1, NULL, DOMID_SELF);
BUG_ON(ret < 0);
If this were ASSERT() in userspace, turning off debugging at build
time would make the evaluations inside of the macro never occur. It
is my opinion that BUG_ON() should behave similarly.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
Home