This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [RFC PATCH 15/33] move segment checks to subarch

To: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [RFC PATCH 15/33] move segment checks to subarch
From: Chris Wright <chrisw@xxxxxxxxxxxx>
Date: Tue, 18 Jul 2006 12:25:33 -0700
Cc: Andrew Morton <akpm@xxxxxxxx>, Zachary Amsden <zach@xxxxxxxxxx>, Jeremy Fitzhardinge <jeremy@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Ian Pratt <ian.pratt@xxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Andi Kleen <ak@xxxxxxx>, Chris Wright <chrisw@xxxxxxxxxxxx>, virtualization@xxxxxxxxxxxxxx, Christian Limpach <Christian.Limpach@xxxxxxxxxxxx>
Delivery-date: Tue, 18 Jul 2006 12:25:13 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1153249601.5467.31.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060718091807.467468000@xxxxxxxxxxxx> <20060718091952.263186000@xxxxxxxxxxxx> <1153249601.5467.31.camel@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/
* Rusty Russell (rusty@xxxxxxxxxxxxxxx) wrote:
> On Tue, 2006-07-18 at 00:00 -0700, Chris Wright wrote:
> > plain text document attachment (i386-segments)
> > We allow for the fact that the guest kernel may not run in ring 0.
> > This requires some abstraction in a few places when setting %cs or
> > checking privilege level (user vs kernel).
> Zach had an alternate patch for this, which didn't assume the kernel ran
> in a compile-time known ring, but is otherwise very similar.  I've put
> it below for discussion (but Zach now tells me the asm parts are not
> required: Zach, can you mod this patch and comment?).

This patch also doesn't have a compile time known ring, it's using
get_kernel_cs() because the Xen method for booting native is dynamic and
would resolve to ring 0 in that case (XENFEAT_supervisor_mode_kernel).

> Your patch #16 finishes the job you started here, by doing the mods to
> entry.S.  I think it's cleaner to have all this in one patch (and it can
> go in almost immediately AFAICT).

I totally agree.  I actually started doing rearranging the patch order
last night and that was one of the bits that got consolidated.  It was
getting light this morning and I gave up since I was wasting lots of
time fixing patch rejects from all the rearranging, and needed a bit of
sleep before KS;-)

> Comments?
> Rusty.
> Name: Kernel Ring Cleanups
> Status: Booted on 2.6.18-rc1
> Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>

Looks fine to me, granted I haven't tried to boot it yet.  I'll double
check and report back.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>