This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] cleanup "struct xenbus_driver"

To: Gerd Hoffmann <kraxel@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH] cleanup "struct xenbus_driver"
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Tue, 11 Jul 2006 17:03:17 +0100
Cc: Xen devel list <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 11 Jul 2006 09:03:43 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <44B3C9CD.4070805@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <44B3542A.20301@xxxxxxx> <44B38E85.2070902@xxxxxxx> <8cf0fb2d74fc4ac3bac78670de4e1476@xxxxxxxxxxxx> <44B3C9CD.4070805@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 11 Jul 2006, at 16:54, Gerd Hoffmann wrote:

I got "Driver 'vbd' needs updating - please use bus_type methods"
messages in the log; seems using both xenbus_frontend->bus->probe() and
xenbus_device->driver->probe() (which the patch does) is the reason for

I've checked what others (pci for example) are doing, they have
pci_driver->probe() and friends too, so that probably is just fine.

Yes, effectively overloading the function pointers looked dodgy to me. They have their own device_driver -specific semantics that we do not share.

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>