This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] [1/4] put xen console message into syslog but x

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] [1/4] put xen console message into syslog but xm dmesg is not affected
From: "MINAI Katsuhito" <minai@xxxxxxxxxxxxxx>
Date: Tue, 11 Jul 2006 10:28:36 +0900 (JST)
Cc: Mark Williamson <mark.williamson@xxxxxxxxxxxx>, Hans-Christian Armingeon <mog.johnny@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>
Delivery-date: Mon, 10 Jul 2006 18:29:06 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
Importance: Normal
In-reply-to: <8f6c63685e997067f1bf7a39d9372c64@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060707170404.E3CC.MINAI@xxxxxxxxxxxxxx> <8f6c63685e997067f1bf7a39d9372c64@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: SquirrelMail/1.4.3a
Hi Keir

Thanks for your comments.
My modification is a simple reading interface that is independent
from the interface of "xc_readconsolering (clear/non-clear)"
that xm dmesg uses. It can be used if "clear" argument is
a negative value.

However, I also think that the "clear" interface is unnecessary.
I think that better solution is one of the following idea:
- modification to have independent read pointer of the buffer
  for each commands and daemons just like reading usual file.
  But, this might be difficult for hypervisor.
- modification to give the responsibility of logging of the message
  to only one daemon. Other commands and daemons must read
  the logging file never to issue xc_readconsolering().

best regards,
Katsuhito Minai

On 2006年  7月月 11日 (火) 12:00 am, Keir Fraser said:
> On 7 Jul 2006, at 09:17, MINAI Katsuhito wrote:
>> [1/4] add read pointer to the xen console ring
>> Signed-off-by: Katsuhito Minai <minai@xxxxxxxxxxxxxx>
> Can you briefly explain the semantics of the modified console
> interface. I'd rather change the interface cleanly than abuse the
> 'clear' field -- we've broken dom0_op compatibility since 3.0.2 anyway,
> so taking the cleaner route is definitely preferable.
>   -- Keir

Xen-devel mailing list