This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Fix argument check of xm reboot command (3)

To: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fix argument check of xm reboot command (3)
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Mon, 10 Jul 2006 15:16:07 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 10 Jul 2006 07:16:37 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <74C6A116752B1Ckanno.masaki@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <74C6A116752B1Ckanno.masaki@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 6 Jul 2006, at 17:08, Masaki Kanno wrote:

 tested unlikely operations about the xm reboot/shutdown command.
As a result, I found the following problems.

Problem 1: Can reboot/shutdown Domain-0 by mistake.
Problem 2: Can not reboot/shutdown domain of domain name '0'.

Wouldn't this be better checked in xend after it has converted domain name to domid, and an appropriate error string returned to the RPC caller? Putting the checking in xm seems a bit unnatural and means that other callers do not benefit.

 -- Keir

Xen-devel mailing list