This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] libxenstore should be executable

To: Jeremy Katz <katzj@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] libxenstore should be executable
From: Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxx>
Date: Tue, 4 Jul 2006 11:57:49 +0200
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 04 Jul 2006 02:59:46 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1151983683.20228.25.camel@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1151983683.20228.25.camel@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.11+cvs20060403
On Mon, Jul 03, 2006 at 11:28:03PM -0400, Jeremy Katz wrote:
> Shared libraries are supposed to be installed +x
> Signed-off-by: Jeremy Katz <katzj@xxxxxxxxxx>
> Jeremy

> diff -r fd6d12935b56 tools/xenstore/Makefile
> --- a/tools/xenstore/Makefile Mon Jul 03 16:07:20 2006 +0100
> +++ b/tools/xenstore/Makefile Mon Jul 03 23:26:44 2006 -0400
> @@ -171,7 +171,7 @@ install: all
>       $(INSTALL_PROG) xenstore-control $(DESTDIR)/usr/bin
>       $(INSTALL_PROG) xenstore-ls $(DESTDIR)/usr/bin
>       $(INSTALL_DIR) -p $(DESTDIR)/usr/$(LIBDIR)
> -     $(INSTALL_DATA) libxenstore.so $(DESTDIR)/usr/$(LIBDIR)
> +     $(INSTALL_PROG) libxenstore.so $(DESTDIR)/usr/$(LIBDIR)
>       $(INSTALL_DATA) xs.h $(DESTDIR)/usr/include
>       $(INSTALL_DATA) xs_lib.h $(DESTDIR)/usr/include

I don't think that needed (almost all libraries in my /usr/lib are -x).
Even then you shouldn't call INSTALL_**PROG** but just create an
INSTALL_LIB or somethign similar..

Vincent Hanquez

Xen-devel mailing list