WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [Xen-changelog] [xen-unstable] [XEN] BUG() places consol

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] Re: [Xen-changelog] [xen-unstable] [XEN] BUG() places console in sync mode.
From: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
Date: Fri, 30 Jun 2006 11:57:55 -0400
Delivery-date: Fri, 30 Jun 2006 08:58:23 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <E1FwL6Q-0007Dv-7W@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <E1FwL6Q-0007Dv-7W@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On Jun 30, 2006, at 11:40 AM, Xen patchbot-unstable wrote:

# HG changeset patch
# User kfraser@xxxxxxxxxxxxxxxxxxxxxxx
# Node ID 1d17ddd9e45d25e1b5fc21e558a4973b70572334
# Parent  25c6ea6d4024c86c2dfd54ef9f44c793e7346ee8
[XEN] BUG() places console in sync mode.
Also move the BUG code out of line.
Original patch from Jimi Xenidis.
diff -r 25c6ea6d4024 -r 1d17ddd9e45d xen/include/xen/lib.h
[...]
+extern void __bug(char *file, int line) __attribute__((noreturn));

I can understand panic() being "noreturn", which it isn't, but __bug () should not, since It should result in some debugging logic (gdb, xmon, whatever) that could potentially continue.

-JX

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>