WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] xen socket buffer allocation fix for non-privile

To: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xen socket buffer allocation fix for non-privileged domain
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Thu, 15 Jun 2006 13:41:03 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 15 Jun 2006 05:41:18 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20060615110140.GE20574%yamahata@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060615110140.GE20574%yamahata@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 15 Jun 2006, at 12:01, Isaku Yamahata wrote:

socket buffer need not to be machine-contiguous for non-priveleged domain. populate physmap hypercall fails with extent order > 0 for non-privileged
domain.
On non-privileged domain of Xen/IA64, this caused some trobles.

I put this in for now but, in general the SIF_PRIVILEGED flag is only set for domain0 and not for other driver domains. Your problem is probably that the guest gives up memory and then cannot reclaim it when the get-contiguous-region request fails, so it then crashes. I'm fixing this by adding an atomic memory-exchange hypercall -- when I've added that you can fix up your create_contiguous_region and I'll remove this change to the skbuff allocation code.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>