WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] balloon question


On 9 Jun 2006, at 10:52, Jan Beulich wrote:

But I think it's prefereable to take the following loop from
i386/mm/init-xen.c and put it in x86/64's mem_init() somewhere:
 for (i = ...->nr_pages; i < max_pfn; i++) {
     ClearPageReserved(...);
     set_page_count(..., 1);
  }

Did you deliberately leave out the increment of totalram_pages that is in i386's respective loop? I have to admit that I can't see why i386 is doing
that, but for symmetry I added it to x86-64's loop, too (balloon_init()
re-writes the variable anyway).

The increment is bogus. Gets overwritten by the balloon driver anyway. I'll remove it from your patch and fix i386 too.

Thanks!

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>