WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [Xen-changelog] [xen-unstable] Expose the exception thro

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] Re: [Xen-changelog] [xen-unstable] Expose the exception thrown by xen.lowlevel.xs.
From: Hollis Blanchard <hollisb@xxxxxxxxxx>
Date: Wed, 07 Jun 2006 10:24:36 -0500
Delivery-date: Wed, 07 Jun 2006 08:24:23 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <E1FnwOT-0001xZ-8K@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: IBM Linux Technology Center
References: <E1FnwOT-0001xZ-8K@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, 2006-06-07 at 11:40 +0000, Xen patchbot-unstable wrote:
> 
> diff -r 647d012b9a36 -r da81a493c8e5 tools/python/xen/lowlevel/xs/xs.c
> --- a/tools/python/xen/lowlevel/xs/xs.c Thu Jun 01 12:11:59 2006 +0100
> +++ b/tools/python/xen/lowlevel/xs/xs.c Thu Jun 01 12:13:11 2006 +0100
...
> @@ -324,13 +333,13 @@ static PyObject *xspy_set_permissions(Xs
>      th = strtoul(thstr, NULL, 16);
>  
>      if (!PyList_Check(perms)) {
> -        PyErr_SetString(PyExc_RuntimeError, "perms must be a list");
> +       xs_set_error(EINVAL);
>          goto exit;
>      }
>      xsperms_n = PyList_Size(perms);
>      xsperms = calloc(xsperms_n, sizeof(struct xs_permissions));
>      if (!xsperms) {
> -        PyErr_SetString(PyExc_RuntimeError, "out of memory");
> +       xs_set_error(ENOMEM);
>          goto exit;
>      }
>      tuple0 = PyTuple_New(0); 

I couldn't help but notice some inconsistent tab/spacing going on...
seems to change throughout the file.

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] Re: [Xen-changelog] [xen-unstable] Expose the exception thrown by xen.lowlevel.xs., Hollis Blanchard <=