 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH, resend] blkfront: ioctls/geometry, 2.6
| To: | "Jan Beulich" <jbeulich@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH, resend] blkfront: ioctls/geometry, 2.6 |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Fri, 2 Jun 2006 11:19:25 +0100 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Fri, 02 Jun 2006 03:19:46 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <4480296D.76E4.0078.0@xxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <4480296D.76E4.0078.0@xxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On 2 Jun 2006, at 11:05, Jan Beulich wrote: Add backing support for HDIO_GETGEO ioctl to blkfront. Inspired by an earlier patch from Charles Coffing. Does this have any effect? It looks to me as though HDIO_GETGEO is handled by block/ioctl.c:blkdev_ioctl(). I also note that *no* other blkdev drivers define their own HDIO_GETGEO handler. Shouldn't we just remove that case from our ioctl switch statement and define a 'getgeo' function hook? Given that this patch can't have any effect, what drove you guys to implement it? :-) -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] x86-64 linux' sys_ioperm(), Keir Fraser |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH, resend] replacement for noirqdebug hack, Keir Fraser |
| Previous by Thread: | [Xen-devel] [PATCH, resend] blkfront: ioctls/geometry, 2.6, Jan Beulich |
| Next by Thread: | Re: [Xen-devel] [PATCH, resend] blkfront: ioctls/geometry, 2.6, Jan Beulich |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
