Re: [Xen-devel] Re: [PATCH 1/6][RESEND] xen: Add NUMA support to Xen

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 15 May 2006, at 18:27, Ryan Harper wrote:

> Well, I *tried* to use drivers/acpi/numa.c first, and I quit after I 
> had
> to pull in more than few headers; it was just too intertwined.  I think
> using the i386 parser and calling into the x86_64 logic should be
> do-able.  I'll give it a go and post back here with the results.
Pulling in a few more header files (presumably from include/acpi?) 
would be okay, as long as you don't end up grabbing loads of .c files. 
But really i don't see the problem here -- drivers/acpi/numa.c hardly 
pulls in very many header files. It grabs acmacros.h and acpi_bus.h, 
both of which Xen has already.
Just take a logical look at that file: it clearly doesn't use much ACPI 
machinery and I really think it should be possible to port it down to 
Xen with not much modification. Unless you can give a concrete example 
why I'm wrong. :-)
I'd _much_ rather do that than have a franken-file of i386 and x86/64 
code.
 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel