[Xen-devel] Re: [RFC PATCH 29/35] Add the Xen virtual console dr

To:	Andrew Morton <akpm@xxxxxxxx>
Subject:	[Xen-devel] Re: [RFC PATCH 29/35] Add the Xen virtual console driver.
From:	Nick Piggin <nickpiggin@xxxxxxxxxxxx>
Date:	Sat, 13 May 2006 22:51:11 +1000
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx, ian.pratt@xxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Chris Wright <chrisw@xxxxxxxxxxxx>, virtualization@xxxxxxxxxxxxxx, Christian.Limpach@xxxxxxxxxxxx
Delivery-date:	Mon, 15 May 2006 00:35:36 -0700
Domainkey-signature:	a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com.au; h=Received:Message-ID:Date:From:User-Agent:X-Accept-Language:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=SfvgLMor3Dp1IUy9zQelEVfInIzW0mUdqUw4pJMGlfEaAsLCJpS4p4f1bqZ45Gop+2TdTzzCwJn9sFcGJN4kEBHLMWcKuMtJu3fGiRTuM9rvU13fLJ1ZuNOFmTzl72NyssofcE7coQQ18jYimD2CPAjiSaXgBaC5JW4zsKP80Go= ;
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<20060513052757.59446e03.akpm@xxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<20060509084945.373541000@xxxxxxxxxxxx> <20060509085159.285105000@xxxxxxxxxxxx> <20060513052757.59446e03.akpm@xxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20051007 Debian/1.7.12-1

Andrew Morton wrote:

+static void kcons_write_dom0(
+       struct console *c, const char *s, unsigned int count)
+{
+       int rc;
+
+       while ((count > 0) &&
+              ((rc = HYPERVISOR_console_io(
+                       CONSOLEIO_write, count, (char *)s)) > 0)) {
+               count -= rc;
+               s += rc;
+       }
+}



must.. not.. mention.. coding.. style..


Someone should write you a script to go through a patch and flag the
most common style mistakes. Have the output formatted to look like
you're replying to the mail, and wire it up to your inbox ;)

--
SUSE Labs, Novell Inc.

Send instant messages to your online friends http://au.messenger.yahoo.com


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

[Xen-devel] Re: [RFC PATCH 33/35] Add the Xenbus sysfs and virtual device hotplug driver., Andrew Morton

Next by Date:

[Xen-devel] Re: [RFC PATCH 29/35] Add the Xen virtual console driver., Andrew Morton

Previous by Thread:

[Xen-devel] Re: [RFC PATCH 29/35] Add the Xen virtual console driver., Andrew Morton

Next by Thread:

[Xen-devel] Re: [RFC PATCH 29/35] Add the Xen virtual console driver., Andrew Morton

Indexes:

[Date] [Thread] [Top] [All Lists]

WARNING - OLD ARCHIVES

xen-devel

[Xen-devel] Re: [RFC PATCH 29/35] Add the Xen virtual console driver.