Index: 2006-04-19/linux-2.6-xen-sparse/arch/i386/kernel/io_apic-xen.c =================================================================== --- 2006-04-19.orig/linux-2.6-xen-sparse/arch/i386/kernel/io_apic-xen.c 2006-04-13 15:53:47.000000000 +0200 +++ 2006-04-19/linux-2.6-xen-sparse/arch/i386/kernel/io_apic-xen.c 2006-04-13 15:56:35.000000000 +0200 @@ -1205,7 +1205,6 @@ u8 irq_vector[NR_IRQ_VECTORS] __read_mos int assign_irq_vector(int irq) { - static int current_vector = FIRST_DEVICE_VECTOR; physdev_op_t op; BUG_ON(irq >= NR_IRQ_VECTORS); @@ -1216,13 +1215,12 @@ int assign_irq_vector(int irq) op.u.irq_op.irq = irq; if (HYPERVISOR_physdev_op(&op)) return -ENOSPC; - current_vector = op.u.irq_op.vector; - vector_irq[current_vector] = irq; + vector_irq[op.u.irq_op.vector] = irq; if (irq != AUTO_ASSIGN) - IO_APIC_VECTOR(irq) = current_vector; + IO_APIC_VECTOR(irq) = op.u.irq_op.vector; - return current_vector; + return op.u.irq_op.vector; } #ifndef CONFIG_XEN Index: 2006-04-19/linux-2.6-xen-sparse/arch/x86_64/kernel/io_apic-xen.c =================================================================== --- 2006-04-19.orig/linux-2.6-xen-sparse/arch/x86_64/kernel/io_apic-xen.c 2006-04-13 15:53:47.000000000 +0200 +++ 2006-04-19/linux-2.6-xen-sparse/arch/x86_64/kernel/io_apic-xen.c 2006-04-13 15:57:17.000000000 +0200 @@ -869,7 +869,6 @@ u8 irq_vector[NR_IRQ_VECTORS] __read_mos int assign_irq_vector(int irq) { - static int current_vector = FIRST_DEVICE_VECTOR; physdev_op_t op; BUG_ON(irq != AUTO_ASSIGN && (unsigned)irq >= NR_IRQ_VECTORS); @@ -880,13 +879,12 @@ int assign_irq_vector(int irq) op.u.irq_op.irq = irq; if (HYPERVISOR_physdev_op(&op)) return -ENOSPC; - current_vector = op.u.irq_op.vector; - vector_irq[current_vector] = irq; + vector_irq[op.u.irq_op.vector] = irq; if (irq != AUTO_ASSIGN) - IO_APIC_VECTOR(irq) = current_vector; + IO_APIC_VECTOR(irq) = op.u.irq_op.vector; - return current_vector; + return op.u.irq_op.vector; } extern void (*interrupt[NR_IRQS])(void); Index: 2006-04-19/xen/arch/x86/io_apic.c =================================================================== --- 2006-04-19.orig/xen/arch/x86/io_apic.c 2006-04-06 17:50:26.000000000 +0200 +++ 2006-04-19/xen/arch/x86/io_apic.c 2006-04-13 16:16:59.000000000 +0200 @@ -48,6 +48,7 @@ atomic_t irq_mis_count; static struct { int pin, apic; } ioapic_i8259 = { -1, -1 }; static DEFINE_SPINLOCK(ioapic_lock); +static DEFINE_SPINLOCK(vector_lock); int skip_ioapic_setup; @@ -661,11 +662,17 @@ u8 irq_vector[NR_IRQ_VECTORS] __read_mos int assign_irq_vector(int irq) { - static int current_vector = FIRST_DYNAMIC_VECTOR, offset = 0; + static unsigned current_vector = FIRST_DYNAMIC_VECTOR, offset = 0; + unsigned vector; BUG_ON(irq >= NR_IRQ_VECTORS); - if (irq != AUTO_ASSIGN && IO_APIC_VECTOR(irq) > 0) + spin_lock(&vector_lock); + + if (irq != AUTO_ASSIGN && IO_APIC_VECTOR(irq) > 0) { + spin_unlock(&vector_lock); return IO_APIC_VECTOR(irq); + } + next: current_vector += 8; @@ -679,16 +686,21 @@ next: if (current_vector > LAST_DYNAMIC_VECTOR) { offset++; - if (!(offset%8)) + if (!(offset%8)) { + spin_unlock(&vector_lock); return -ENOSPC; + } current_vector = FIRST_DYNAMIC_VECTOR + offset; } - vector_irq[current_vector] = irq; + vector = current_vector; + vector_irq[vector] = irq; if (irq != AUTO_ASSIGN) - IO_APIC_VECTOR(irq) = current_vector; + IO_APIC_VECTOR(irq) = vector; + + spin_unlock(&vector_lock); - return current_vector; + return vector; } static struct hw_interrupt_type ioapic_level_type;