This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 1/2] Make physdev_op common

To: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 1/2] Make physdev_op common
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Fri, 28 Apr 2006 15:12:57 +0100
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 28 Apr 2006 07:13:14 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <571ACEFD467F7749BC50E0A98C17CDD8094E7BB0@pdsmsx403>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <571ACEFD467F7749BC50E0A98C17CDD8094E7BB0@pdsmsx403>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

Hmmm, actually now I think about this some more I'm not so sure it's a good idea after all. Firstly, other architectures (e.g., ppc) may not want all of the physdev operations that you have chosen to make common. Secondly, it's not exactly a lot of code to duplicate in arch/ia64 -- it's only a switch statement with some very basic argument checking (which, even so, we may want to change in future for x86) and then calls out to arch-specific functions that actually do the work. So there's an argument for simply duplicating this hypercall code.

I guess maybe it might make sense if we were to try and pull out some common elements of guest IRQ handling. Then at least the physdev ops concerned with irq management might arguably be common. But even then, having an arch-specific hypercall calling out to code in common/ is okay.

What do you think?

 -- Keir

On 28 Apr 2006, at 08:16, Tian, Kevin wrote:

Signed-off-by Kevin Tian <kevin.tian@xxxxxxxxx>

Xen-devel mailing list

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>