Re: [Xen-devel] [PATCH 1/2] Make physdev_op common

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

Hmmm, actually now I think about this some more I'm not so sure it's a 
good idea after all. Firstly, other architectures (e.g., ppc) may not 
want all of the physdev operations that you have chosen to make common. 
Secondly, it's not exactly a lot of code to duplicate in arch/ia64 -- 
it's only a switch statement with some very basic argument checking 
(which, even so, we may want to change in future for x86) and then 
calls out to arch-specific functions that actually do the work. So 
there's an argument for simply duplicating this hypercall code.
I guess maybe it might make sense if we were to try and pull out some 
common elements of guest IRQ handling. Then at least the physdev ops 
concerned with irq management might arguably be common. But even then, 
having an arch-specific hypercall calling out to code in common/ is 
okay.
What do you think?

 -- Keir

On 28 Apr 2006, at 08:16, Tian, Kevin wrote:

> Signed-off-by Kevin Tian <kevin.tian@xxxxxxxxx>
>
> Thanks,
> Kevin
> <physdev_common.patch>_______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel