This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 1/2] balloon driver: relax BUG_ON() in increasee_

On 28 Apr 2006, at 08:23, Isaku Yamahata wrote:

x86 phys_to_machine_ampping_valid() includes a check of the
autotranslate feature flag. It always returns 1 if that flag is set.

Yes. So when autotranslate feature flag is set,
BUG_ON(phys_to_machine_mapping_valid(pfn)) becomes BUG_ON(1)
which results in kernel panic.
This means that the balloon driver can't be used with autotranslate
feature flag set.
Is this really your intention?

Oh yes, good point.

Actually I guess it's not clear what phys_to_machine_mapping_valid() shoudl return for auto-translated guests. Possibly it should assert that autotranslate is false.

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>