This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] [PATCH] linux: mor assign_irq_vector() adjustments

To: "Jan Beulich" <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] linux: mor assign_irq_vector() adjustments
From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
Date: Wed, 26 Apr 2006 11:09:16 +0800
Delivery-date: Tue, 25 Apr 2006 20:09:47 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcZoZTCbwcjlWpeiQuyDSwYXrPqCKwAeMDLQ
Thread-topic: [Xen-devel] [PATCH] linux: mor assign_irq_vector() adjustments
>From: Jan Beulich
>Sent: 2006年4月25日 20:39
>Instead of adding locking to also protect irq_vector[] in xenlinux, this
>patch adds verification that the vector passed
>up from Xen for a certain IRQ is matching a potential previously obtained
>value. Besides that, two minor cleanup hunks.

Is it useful to add that type of detect in xenlinux? Since lock has 
been added into xen, it's always the first one holding lock to trigger 
allocation process while the latter one getting cached vector returned
directly. In this case, xen promises the consistence and it's always 
safe even two paths are writing irq_vector table simultaneously since 
two paths see same value...


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>