This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] pci-dma-xen.c change necessary for xen/ia64

To: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] pci-dma-xen.c change necessary for xen/ia64
From: Muli Ben-Yehuda <muli@xxxxxxxxxx>
Date: Tue, 25 Apr 2006 11:44:25 +0300
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 25 Apr 2006 01:44:51 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20060425043052.GF26453%yamahata@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060425043052.GF26453%yamahata@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.11
On Tue, Apr 25, 2006 at 01:30:52PM +0900, Isaku Yamahata wrote:
> xenLinux/ia64 with dom0 vp model uses
> linux-2.6-xen-sparse/arch/i386/kernel/pci-dma-xen.c.

Err, why?

> But it has its own dma_map_page(), dma_declare_coheremnt_memory() and their
> families. So those in pci-dma-xen.c are unnecessary. #ifdef out
> them.

Won't it be cleaner for IA64 to have a DMA API implementation for each
different mode of operation? if code can be consolidated between
different implementations it should be put in a common file, under
arch/ia64 or in lib/ or drivers/, depending on the usage. The #ifdef
approach (not to mention using one arch's files from another) #is
going to be severely frowned upon upstream.


Xen-devel mailing list