This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] PATCH: console.c: use ioremap instead of __va to map vid

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] PATCH: console.c: use ioremap instead of __va to map video memory
From: Muli Ben-Yehuda <mulix@xxxxxxxxx>
Date: Mon, 24 Apr 2006 10:01:05 +0300
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 24 Apr 2006 03:42:08 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <91a13822bf745def349861a374696d0c@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <200604141437.22342.Tristan.Gingold@xxxxxxxx> <20060414144610.GP10412@xxxxxxxxxxxxxxxxxxx> <91a13822bf745def349861a374696d0c@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.11+cvs20060126
On Fri, Apr 14, 2006 at 07:38:18PM +0100, Keir Fraser wrote:
> On 14 Apr 2006, at 15:46, Muli Ben-Yehuda wrote:
> >The comment in asm-x86/io.h says "we don't need a real ioremap on
> >Xen/x86", but I think we do need it for the IOMMU work on x86-64,
> >since the hypervisor will need to map the IOMMU's internal register
> >area for things like cache flushing. Is there a fundamental objection
> >to a real ioremap for x86?
> No, it got removed as it wasn't used, but it can easily be added back. 
> It's particularly easy since we probably don't need iounmap().

Hmm, looking at the hg logs, it looks like ioremap() was added for
x86-64 with the current __va() implementation. Can you please point me
at the old version?

Muli Ben-Yehuda
http://www.mulix.org | http://mulix.livejournal.com/

Xen-devel mailing list