This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] linux: xenbus_be currently doesn't build properl

To: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] linux: xenbus_be currently doesn't build properly as a module
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Thu, 20 Apr 2006 14:46:10 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 20 Apr 2006 06:46:32 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <4447A9BB.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <44479695.76E4.0078.0@xxxxxxxxxx> <88c3dae3cc8a048a507a1a3549475c65@xxxxxxxxxxxx> <4447A9BB.76E4.0078.0@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 20 Apr 2006, at 14:33, Jan Beulich wrote:

There's only one user of these functions right now, so the patch for
this proper fix won't be very big.

I specifically didn't do it this proper way because of the comment in the function saying doing it the raw way would be so much simpler - but if that in fact doesn't

The disadvantage of exposing the vmarea at the interface is outweighed by the advantage of being able to build as a module imo. Unless there is ever going to be a find_vm_area() call, this has to be considered the proper long-term fix to make it buildable as a module.

 -- Keir

Xen-devel mailing list