This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] change dom0 headers path

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] change dom0 headers path
From: John Levon <levon@xxxxxxxxxxxxxxxxx>
Date: Thu, 20 Apr 2006 14:13:10 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 20 Apr 2006 06:13:30 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <f6b99d6b2ef717390f6ae100e1b87bf2@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060420123936.GA840@xxxxxxxxxxxxxxxxxxxx> <f6b99d6b2ef717390f6ae100e1b87bf2@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Thu, Apr 20, 2006 at 02:00:07PM +0100, Keir Fraser wrote:

> >Fairly obviously, we need to clean up the hard-coded "linux" names used
> >in includes. This is the first step in a number of changes around
> >letting dom0 build on something other than Linux.
> >
> >What are the plans for these headers when the Linux kernel lives in 
> >some
> >place other than the xen tree itself? We'd like to be able to share the
> >structure definitions, but our ioctl values will differ from Linux's...
> I'd prefer an interfacing library (or libraries) that can target Linux 
> interfaces, Sun interfaces, etc.

My understanding is that libxc *is* that library.

> Maybe this only needs to be done for evtchn interfaces. I would have 
> hoped that libxenctrl and libxenguest would hide privcmd interfaces. I 
> wonder why so many things include <linux/privcmd.h>?

Code is using ioctl() where it should be using a helper function.  I
don't mind looking into cleaning these things up at some point, but it
doesn't seem critical right now. But we'd like to get a firm grasp on
header naming so we can deal with the unfortunate two-way dependency
these headers have between dom0 and dom0 userspace.

IOW, I agree with you, but I think the patch needs to go in regardless.
In particular, something like my patch will still be needed, even if
it's just private to tools/libxc/.


Xen-devel mailing list